staging: rtl8192e: Remove unchanged variable dig_enable_flag
authorPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Fri, 13 Oct 2023 14:43:46 +0000 (16:43 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 15 Oct 2023 16:20:45 +0000 (18:20 +0200)
Remove variable dig_enable_flag as its value is set to 1 at
initialization. No further writes to dig_enable_flag are done. The
equations result accordingly. Remove dead code.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/24a9245840093c5a14124f9fc896433c7d85d18c.1697127817.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
drivers/staging/rtl8192e/rtl8192e/rtl_dm.h

index 01abe1e484683451d10319195ad049dfcd04abad..bbd18b6cc252711a8dbd69ca8d7543b080ee67c6 100644 (file)
@@ -913,8 +913,6 @@ static void _rtl92e_dm_dig_init(struct net_device *dev)
 {
        struct r8192_priv *priv = rtllib_priv(dev);
 
-       dm_digtable.dig_enable_flag     = true;
-
        dm_digtable.dig_algorithm = DIG_ALGO_BY_RSSI;
 
        dm_digtable.dig_algorithm_switch = 0;
@@ -941,9 +939,6 @@ static void _rtl92e_dm_dig_init(struct net_device *dev)
 
 static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev)
 {
-       if (!dm_digtable.dig_enable_flag)
-               return;
-
        if (dm_digtable.dig_algorithm == DIG_ALGO_BY_FALSE_ALARM)
                _rtl92e_dm_ctrl_initgain_byrssi_false_alarm(dev);
        else if (dm_digtable.dig_algorithm == DIG_ALGO_BY_RSSI)
@@ -976,9 +971,6 @@ static void _rtl92e_dm_ctrl_initgain_byrssi_driver(struct net_device *dev)
        u8 i;
        static u8       fw_dig;
 
-       if (!dm_digtable.dig_enable_flag)
-               return;
-
        if (dm_digtable.dig_algorithm_switch)
                fw_dig = 0;
        if (fw_dig <= 3) {
@@ -1007,9 +999,6 @@ static void _rtl92e_dm_ctrl_initgain_byrssi_false_alarm(struct net_device *dev)
        struct r8192_priv *priv = rtllib_priv(dev);
        u8 i;
 
-       if (!dm_digtable.dig_enable_flag)
-               return;
-
        if (dm_digtable.dig_algorithm_switch) {
                dm_digtable.dig_state = DM_STA_DIG_MAX;
                for (i = 0; i < 3; i++)
index 5ae2bf46715847de499bac12b1ded6ef47268fe1..faf08763c34046e4ec5d266ab06aeb93b9ad1a2c 100644 (file)
@@ -50,7 +50,6 @@
 
 /*------------------------------Define structure----------------------------*/
 struct dig_t {
-       u8              dig_enable_flag;
        u8              dig_algorithm;
        u8              dig_algorithm_switch;