RDMA/hns: Repacing 'dseg_len' by macros in fill_ext_sge_inl_data()
authorLuoyouming <luoyouming@huawei.com>
Thu, 22 Sep 2022 12:33:13 +0000 (20:33 +0800)
committerJason Gunthorpe <jgg@nvidia.com>
Tue, 27 Sep 2022 13:15:25 +0000 (10:15 -0300)
The sge size is known to be constant, so it's unnecessary to use sizeof to
calculate.

Link: https://lore.kernel.org/r/20220922123315.3732205-11-xuhaoyue1@hisilicon.com
Signed-off-by: Luoyouming <luoyouming@huawei.com>
Signed-off-by: Haoyue Xu <xuhaoyue1@hisilicon.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/hns/hns_roce_hw_v2.c

index 31bfea15cdfcfa392ceb7ccca9825f805f2460b9..e1716f100dce4074b6df79babb5b8e07a66d7fc7 100644 (file)
@@ -193,8 +193,7 @@ static int fill_ext_sge_inl_data(struct hns_roce_qp *qp,
                                 unsigned int *sge_idx, u32 msg_len)
 {
        struct ib_device *ibdev = &(to_hr_dev(qp->ibqp.device))->ib_dev;
-       unsigned int dseg_len = sizeof(struct hns_roce_v2_wqe_data_seg);
-       unsigned int ext_sge_sz = qp->sq.max_gs * dseg_len;
+       unsigned int ext_sge_sz = qp->sq.max_gs * HNS_ROCE_SGE_SIZE;
        unsigned int left_len_in_pg;
        unsigned int idx = *sge_idx;
        unsigned int i = 0;
@@ -222,7 +221,7 @@ static int fill_ext_sge_inl_data(struct hns_roce_qp *qp,
                if (len <= left_len_in_pg) {
                        memcpy(dseg, addr, len);
 
-                       idx += len / dseg_len;
+                       idx += len / HNS_ROCE_SGE_SIZE;
 
                        i++;
                        if (i >= wr->num_sge)
@@ -237,7 +236,7 @@ static int fill_ext_sge_inl_data(struct hns_roce_qp *qp,
 
                        len -= left_len_in_pg;
                        addr += left_len_in_pg;
-                       idx += left_len_in_pg / dseg_len;
+                       idx += left_len_in_pg / HNS_ROCE_SGE_SIZE;
                        dseg = hns_roce_get_extend_sge(qp,
                                                idx & (qp->sge.sge_cnt - 1));
                        left_len_in_pg = 1 << HNS_HW_PAGE_SHIFT;