PCI/ASPM: Reduce severity of common clock config message
authorChris Packham <chris.packham@alliedtelesis.co.nz>
Mon, 23 Mar 2020 03:55:30 +0000 (16:55 +1300)
committerBjorn Helgaas <bhelgaas@google.com>
Sat, 28 Mar 2020 20:09:22 +0000 (15:09 -0500)
When the UEFI/BIOS or bootloader has not initialised a PCIe device we would
get the following message:

  kern.warning: pci 0000:00:01.0: ASPM: current common clock configuration is broken, reconfiguring

"warning" and "broken" are slightly misleading. On an embedded system it is
quite possible for the bootloader to avoid configuring PCIe devices if they
are not needed.

Downgrade the message to pci_info() and change "broken" to "inconsistent"
since we fix up the inconsistency in the code immediately following the
message (and emit an error if that fails).

Link: https://lore.kernel.org/r/20200323035530.11569-1-chris.packham@alliedtelesis.co.nz
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/pcie/aspm.c

index c2596e79ec63f77f711f01883e59ac2f0994c770..2378ed692534684023e7534a57c636917d507140 100644 (file)
@@ -273,7 +273,7 @@ static void pcie_aspm_configure_common_clock(struct pcie_link_state *link)
                }
                if (consistent)
                        return;
-               pci_warn(parent, "ASPM: current common clock configuration is broken, reconfiguring\n");
+               pci_info(parent, "ASPM: current common clock configuration is inconsistent, reconfiguring\n");
        }
 
        /* Configure downstream component, all functions */