hw/sd/sdcard: Remove ACMD6 handler for SPI mode
authorPhilippe Mathieu-Daudé <philmd@linaro.org>
Thu, 20 Jun 2024 12:43:13 +0000 (14:43 +0200)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Mon, 24 Jun 2024 08:41:42 +0000 (10:41 +0200)
There is no ACMD6 command in SPI mode, remove the pointless
handler introduced in commit 946897ce18 ("sdcard: handles
more commands in SPI mode"). Keep sd_cmd_unimplemented()
since we'll reuse it later.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Tested-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240621080554.18986-8-philmd@linaro.org>

hw/sd/sd.c

index 6e346e28ca47d8c25694f10263e8106b1c3212ee..08a6d0aff86f97cccf01672ed1f209238bb674c3 100644 (file)
@@ -1012,6 +1012,7 @@ static sd_rsp_type_t sd_cmd_illegal(SDState *sd, SDRequest req)
 }
 
 /* Commands that are recognised but not yet implemented. */
+__attribute__((unused))
 static sd_rsp_type_t sd_cmd_unimplemented(SDState *sd, SDRequest req)
 {
     qemu_log_mask(LOG_UNIMP, "%s: CMD%i not implemented\n",
@@ -2154,7 +2155,6 @@ static const SDProto sd_proto_spi = {
         [52 ... 54] = sd_cmd_illegal,
     },
     .acmd = {
-        [6]         = sd_cmd_unimplemented,
         [41]        = spi_cmd_SEND_OP_COND,
     },
 };