input: raspberrypi-ts: Release firmware handle when not needed
authorNicolas Saenz Julienne <nsaenzjulienne@suse.de>
Mon, 18 Jan 2021 12:32:41 +0000 (13:32 +0100)
committerNicolas Saenz Julienne <nsaenzjulienne@suse.de>
Mon, 22 Mar 2021 16:59:51 +0000 (17:59 +0100)
There is no use for the firmware interface after getting the touch
buffer address, so release it.

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
drivers/input/touchscreen/raspberrypi-ts.c

index ef6aaed217cfb5094126e06c5ea932769f878bc7..5000f5fd9ec387b96203f5b53c0df071c63fa0b7 100644 (file)
@@ -160,7 +160,7 @@ static int rpi_ts_probe(struct platform_device *pdev)
        touchbuf = (u32)ts->fw_regs_phys;
        error = rpi_firmware_property(fw, RPI_FIRMWARE_FRAMEBUFFER_SET_TOUCHBUF,
                                      &touchbuf, sizeof(touchbuf));
-
+       rpi_firmware_put(fw);
        if (error || touchbuf != 0) {
                dev_warn(dev, "Failed to set touchbuf, %d\n", error);
                return error;