iio: accel: bma180: Simplify with dev_err_probe()

Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20200829064726.26268-1-krzk@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
index 5b7a467c7b271b74f1b63a3c49eed061e5ca1412..448faed001fd5e4ab62a1d7b64b3a7dd0eb5012d 100644 (file)
--- a/drivers/iio/accel/bma180.c
+++ b/drivers/iio/accel/bma180.c
@@ -1000,19 +1000,15 @@ static int bma180_probe(struct i2c_client *client,
                return ret;
 
        data->vdd_supply = devm_regulator_get(dev, "vdd");
-       if (IS_ERR(data->vdd_supply)) {
-               if (PTR_ERR(data->vdd_supply) != -EPROBE_DEFER)
-                       dev_err(dev, "Failed to get vdd regulator %d\n",
-                               (int)PTR_ERR(data->vdd_supply));
-               return PTR_ERR(data->vdd_supply);
-       }
+       if (IS_ERR(data->vdd_supply))
+               return dev_err_probe(dev, PTR_ERR(data->vdd_supply),
+                                    "Failed to get vdd regulator\n");
+
        data->vddio_supply = devm_regulator_get(dev, "vddio");
-       if (IS_ERR(data->vddio_supply)) {
-               if (PTR_ERR(data->vddio_supply) != -EPROBE_DEFER)
-                       dev_err(dev, "Failed to get vddio regulator %d\n",
-                               (int)PTR_ERR(data->vddio_supply));
-               return PTR_ERR(data->vddio_supply);
-       }
+       if (IS_ERR(data->vddio_supply))
+               return dev_err_probe(dev, PTR_ERR(data->vddio_supply),
+                                    "Failed to get vddio regulator\n");
+
        /* Typical voltage 2.4V these are min and max */
        ret = regulator_set_voltage(data->vdd_supply, 1620000, 3600000);
        if (ret)