gfs2: Make sure not to return short direct writes
authorAndreas Gruenbacher <agruenba@redhat.com>
Thu, 24 Mar 2022 22:13:26 +0000 (23:13 +0100)
committerAndreas Gruenbacher <agruenba@redhat.com>
Thu, 24 Mar 2022 22:40:43 +0000 (23:40 +0100)
When direct writes fail with -ENOTBLK because we're writing into a
hole (gfs2_iomap_begin()) or because of a page invalidation failure
(iomap_dio_rw()), we're falling back to buffered writes.  In that case,
when we lose the inode glock in gfs2_file_buffered_write(), we want to
re-acquire it instead of returning a short write.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
fs/gfs2/file.c

index edc588465a4b6b9bf52e5387b0b3412bc2ad7a09..22b41acfbbc39a008dddb61d2b66fee883cb06c2 100644 (file)
@@ -1069,7 +1069,7 @@ retry_under_glock:
                        from->count = min(from->count, window_size - leftover);
                        if (gfs2_holder_queued(gh))
                                goto retry_under_glock;
-                       if (read)
+                       if (read && !(iocb->ki_flags & IOCB_DIRECT))
                                goto out_uninit;
                        goto retry;
                }