drivers: gpio: bt8xx: prefer dev_err()/dev_warn() over of raw printk
authorEnrico Weigelt, metux IT consult <info@metux.net>
Thu, 3 Dec 2020 18:24:21 +0000 (19:24 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 8 Dec 2020 08:41:32 +0000 (09:41 +0100)
For logging in device contexts, dev_*() functions are preferred over
raw printk(), which also print out device name.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Link: https://lore.kernel.org/r/20201203182423.5499-1-info@metux.net
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-bt8xx.c

index a6f30ad6750f8a154f570c8c5fce1a4e2d24bd3c..7920cf2567988d1be49696a1153dfae036e3ece4 100644 (file)
@@ -175,13 +175,13 @@ static int bt8xxgpio_probe(struct pci_dev *dev,
 
        err = pci_enable_device(dev);
        if (err) {
-               printk(KERN_ERR "bt8xxgpio: Can't enable device.\n");
+               dev_err(&dev->dev, "can't enable device.\n");
                return err;
        }
        if (!devm_request_mem_region(&dev->dev, pci_resource_start(dev, 0),
                                pci_resource_len(dev, 0),
                                "bt8xxgpio")) {
-               printk(KERN_WARNING "bt8xxgpio: Can't request iomem (0x%llx).\n",
+               dev_warn(&dev->dev, "can't request iomem (0x%llx).\n",
                       (unsigned long long)pci_resource_start(dev, 0));
                err = -EBUSY;
                goto err_disable;
@@ -191,7 +191,7 @@ static int bt8xxgpio_probe(struct pci_dev *dev,
 
        bg->mmio = devm_ioremap(&dev->dev, pci_resource_start(dev, 0), 0x1000);
        if (!bg->mmio) {
-               printk(KERN_ERR "bt8xxgpio: ioremap() failed\n");
+               dev_err(&dev->dev, "ioremap() failed\n");
                err = -EIO;
                goto err_disable;
        }
@@ -207,7 +207,7 @@ static int bt8xxgpio_probe(struct pci_dev *dev,
        bt8xxgpio_gpio_setup(bg);
        err = gpiochip_add_data(&bg->gpio, bg);
        if (err) {
-               printk(KERN_ERR "bt8xxgpio: Failed to register GPIOs\n");
+               dev_err(&dev->dev, "failed to register GPIOs\n");
                goto err_disable;
        }