ASoC: hdmi-codec: remove useless initialization
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 12 Mar 2021 18:22:33 +0000 (12:22 -0600)
committerMark Brown <broonie@kernel.org>
Thu, 18 Mar 2021 13:50:43 +0000 (13:50 +0000)
Fix cppcheck warning:

sound/soc/codecs/hdmi-codec.c:745:5: style: Redundant initialization
for 'cf'. The initialized value is overwritten before it is
read. [redundantInitialization]
 cf = dai->playback_dma_data;
    ^
sound/soc/codecs/hdmi-codec.c:738:31: note: cf is initialized
 struct hdmi_codec_daifmt *cf = dai->playback_dma_data;
                              ^
sound/soc/codecs/hdmi-codec.c:745:5: note: cf is overwritten
 cf = dai->playback_dma_data;
    ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210312182246.5153-11-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/hdmi-codec.c

index 422539f933debf038e17061cee823a9c564b9a5c..83e74ddccf5985edef60f063070941a12b506e18 100644 (file)
@@ -735,7 +735,7 @@ static int hdmi_codec_set_jack(struct snd_soc_component *component,
 
 static int hdmi_dai_spdif_probe(struct snd_soc_dai *dai)
 {
-       struct hdmi_codec_daifmt *cf = dai->playback_dma_data;
+       struct hdmi_codec_daifmt *cf;
        int ret;
 
        ret = hdmi_dai_probe(dai);