objtool: Remove "ANNOTATE_NOENDBR on ENDBR" warning
authorJosh Poimboeuf <jpoimboe@kernel.org>
Thu, 18 Aug 2022 16:26:57 +0000 (09:26 -0700)
committerPeter Zijlstra <peterz@infradead.org>
Fri, 19 Aug 2022 17:47:57 +0000 (19:47 +0200)
This warning isn't very useful: why would you put ANNOTATE_NOENDBR on
ENDBR, and if you did, what's the harm?

And thus far it's only found one non-bug, where the
'__end_entry_SYSENTER_compat' label happens to land on the ENDBR from
entry_SYSCALL_compat:

  vmlinux.o: warning: objtool: entry_SYSCALL_compat+0x0: ANNOTATE_NOENDBR on ENDBR

.. which is fine.  Just remove the warning.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/142341a5dafdfc788e4c95b9e226a6eefc9b626e.1660839773.git.jpoimboe@kernel.org
tools/objtool/check.c

index b012d987a6586c0c10a16f982d5850af129e9cc1..8b8c8f74a77585be7aa2e83a33d2bfb135fc139b 100644 (file)
@@ -2102,9 +2102,6 @@ static int read_noendbr_hints(struct objtool_file *file)
                        return -1;
                }
 
-               if (insn->type == INSN_ENDBR)
-                       WARN_FUNC("ANNOTATE_NOENDBR on ENDBR", insn->sec, insn->offset);
-
                insn->noendbr = 1;
        }