usb: typec: ucsi: correctly access opcode
authorMin-Hua Chen <minhuadotchen@gmail.com>
Tue, 23 May 2023 16:23:12 +0000 (00:23 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 29 May 2023 14:17:39 +0000 (15:17 +0100)
hdr->opcode is __le32 type, use le32_to_cpu() to cast opcode
to integer in the switch..case statement to fix the following
sparse warnings:

drivers/usb/typec/ucsi/ucsi_glink.c:248:20: sparse: warning: restricted __le32 degrades to integer
drivers/usb/typec/ucsi/ucsi_glink.c:248:20: sparse: warning: restricted __le32 degrades to integer
drivers/usb/typec/ucsi/ucsi_glink.c:248:20: sparse: warning: restricted __le32 degrades to integer

No functional change.

Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20230523162314.114274-1-minhuadotchen@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/ucsi/ucsi_glink.c

index b454a5159896a908341b8a8b1fd648d4f25a54e0..1fe9cb5b6bd96dcdcb850541181ad4ab4da261cb 100644 (file)
@@ -245,7 +245,7 @@ static void pmic_glink_ucsi_callback(const void *data, size_t len, void *priv)
        struct pmic_glink_ucsi *ucsi = priv;
        const struct pmic_glink_hdr *hdr = data;
 
-       switch (hdr->opcode) {
+       switch (le32_to_cpu(hdr->opcode)) {
        case UC_UCSI_READ_BUF_REQ:
                pmic_glink_ucsi_read_ack(ucsi, data, len);
                break;