media: i2c: ov5695: Drop check for reentrant .s_stream()
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Thu, 14 Sep 2023 18:16:33 +0000 (21:16 +0300)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 27 Sep 2023 07:39:59 +0000 (09:39 +0200)
The subdev .s_stream() operation shall not be called to start streaming
on an already started subdev, or stop streaming on a stopped subdev.
Remove the check that guards against that condition.

The streaming field of the driver's private structure is now unused,
drop it as well.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/i2c/ov5695.c

index 8d1c3a673c23a22229392f0742b18c35c9e1f93c..c8f57ce1578dccc909db31886b928dd306d4eb19 100644 (file)
@@ -108,7 +108,6 @@ struct ov5695 {
        struct v4l2_ctrl        *vblank;
        struct v4l2_ctrl        *test_pattern;
        struct mutex            mutex;
-       bool                    streaming;
        const struct ov5695_mode *cur_mode;
 };
 
@@ -935,9 +934,6 @@ static int ov5695_s_stream(struct v4l2_subdev *sd, int on)
        int ret = 0;
 
        mutex_lock(&ov5695->mutex);
-       on = !!on;
-       if (on == ov5695->streaming)
-               goto unlock_and_return;
 
        if (on) {
                ret = pm_runtime_resume_and_get(&client->dev);
@@ -955,8 +951,6 @@ static int ov5695_s_stream(struct v4l2_subdev *sd, int on)
                pm_runtime_put(&client->dev);
        }
 
-       ov5695->streaming = on;
-
 unlock_and_return:
        mutex_unlock(&ov5695->mutex);