projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
7bc195c
)
scsi: ps3rom: Call scsi_done() directly
author
Bart Van Assche
<bvanassche@acm.org>
Thu, 7 Oct 2021 20:28:57 +0000
(13:28 -0700)
committer
Martin K. Petersen
<martin.petersen@oracle.com>
Sun, 17 Oct 2021 01:31:40 +0000
(21:31 -0400)
Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.
Link:
https://lore.kernel.org/r/20211007202923.2174984-63-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ps3rom.c
patch
|
blob
|
history
diff --git
a/drivers/scsi/ps3rom.c
b/drivers/scsi/ps3rom.c
index 0f4b99d92f1292dee3829d9a23c6db8b1061ae2c..08e970300b3f0efaa49bf4c1c487183d27f25478 100644
(file)
--- a/
drivers/scsi/ps3rom.c
+++ b/
drivers/scsi/ps3rom.c
@@
-209,7
+209,6
@@
static int ps3rom_queuecommand_lck(struct scsi_cmnd *cmd,
int res;
priv->curr_cmd = cmd;
- cmd->scsi_done = done;
opcode = cmd->cmnd[0];
/*
@@
-237,7
+236,7
@@
static int ps3rom_queuecommand_lck(struct scsi_cmnd *cmd,
scsi_build_sense(cmd, 0, ILLEGAL_REQUEST, 0, 0);
cmd->result = res;
priv->curr_cmd = NULL;
-
cmd->
scsi_done(cmd);
+ scsi_done(cmd);
}
return 0;
@@
-321,7
+320,7
@@
static irqreturn_t ps3rom_interrupt(int irq, void *data)
done:
priv->curr_cmd = NULL;
-
cmd->
scsi_done(cmd);
+ scsi_done(cmd);
return IRQ_HANDLED;
}