staging: rtl8192e: Remove entry .rx_check_stuc.. from struct rtl819x_ops
authorPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Tue, 21 Feb 2023 20:53:17 +0000 (21:53 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 Mar 2023 16:04:59 +0000 (17:04 +0100)
Remove entry .rx_check_stuck_handler and replace it with function name
rtl92e_is_rx_stuck. This increases readability of the code.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/6538f1e158664837f6d1e7a20583ff20fc4f1403.1677010997.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl8192e/rtl_core.c
drivers/staging/rtl8192e/rtl8192e/rtl_core.h

index 410c03833b9f8675723611bc254d8b032992af20..15eab612b08f70e003d8116c80033b4f498a7483 100644 (file)
@@ -30,7 +30,6 @@ static const struct rtl819x_ops rtl819xp_ops = {
        .link_change                    = rtl92e_link_change,
        .rx_command_packet_handler = NULL,
        .irq_clear                      = rtl92e_clear_irq,
-       .rx_check_stuck_handler = rtl92e_is_rx_stuck,
 };
 
 static struct pci_device_id rtl8192_pci_id_tbl[] = {
@@ -1063,9 +1062,7 @@ static enum reset_type _rtl92e_tx_check_stuck(struct net_device *dev)
 
 static enum reset_type _rtl92e_rx_check_stuck(struct net_device *dev)
 {
-       struct r8192_priv *priv = rtllib_priv(dev);
-
-       if (priv->ops->rx_check_stuck_handler(dev))
+       if (rtl92e_is_rx_stuck(dev))
                return RESET_TYPE_SILENT;
 
        return RESET_TYPE_NORESET;
index 87be8aaa7822e696038fe1ef577bc7620621010c..43e1c651e6d23057d60fd498eb107b5f61c799b6 100644 (file)
@@ -211,7 +211,6 @@ struct rtl819x_ops {
                                          struct sk_buff *skb,
                                          struct rx_desc *pdesc);
        void (*irq_clear)(struct net_device *dev);
-       bool (*rx_check_stuck_handler)(struct net_device *dev);
 };
 
 struct r8192_priv {