staging: sm750fb: Remove unused return variable in program_mode_registers()
authorDorcas AnonoLitunya <anonolitunya@gmail.com>
Thu, 19 Oct 2023 10:13:37 +0000 (13:13 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 21 Oct 2023 10:01:01 +0000 (12:01 +0200)
Drops variable ret as it is unused in the code. This therefore modifies
the return type of program_mode_registers() to void from int since the
return value is being ignored in all function calls. This improves code
readability and maintainability.

Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com>
Link: https://lore.kernel.org/r/20231019101348.22076-3-anonolitunya@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/sm750fb/ddk750_mode.c

index f3f354831617211fdef45fcaab5b630932f0bcbd..3b25892af71337d673ebbc5b49067fe9cfc031ac 100644 (file)
@@ -75,10 +75,9 @@ display_control_adjust_SM750LE(struct mode_parameter *mode_param,
 }
 
 /* only timing related registers will be  programed */
-static int program_mode_registers(struct mode_parameter *mode_param,
-                                 struct pll_value *pll)
+static void program_mode_registers(struct mode_parameter *mode_param,
+                                  struct pll_value *pll)
 {
-       int ret = 0;
        int cnt = 0;
        unsigned int tmp, reg;
 
@@ -201,10 +200,7 @@ static int program_mode_registers(struct mode_parameter *mode_param,
                                break;
                        poke32(PANEL_DISPLAY_CTRL, tmp | reg);
                }
-       } else {
-               ret = -1;
        }
-       return ret;
 }
 
 int ddk750_set_mode_timing(struct mode_parameter *parm, enum clock_type clock)