iio: adc: stm32-adc: use 'time_left' variable with wait_for_completion_interruptible_...
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Mon, 29 Apr 2024 11:33:08 +0000 (13:33 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 29 Apr 2024 20:06:18 +0000 (21:06 +0100)
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_interruptible_timeout() causing patterns like:

timeout = wait_for_completion_interruptible_timeout(...)
if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20240429113313.68359-6-wsa+renesas@sang-engineering.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/stm32-adc.c

index 36add95212c370f9b6d4cc4c8bc93c644a8fdea5..375aa7720f80426651f43b21a4d0c30dcadab3c1 100644 (file)
@@ -1408,7 +1408,7 @@ static int stm32_adc_single_conv(struct iio_dev *indio_dev,
        struct stm32_adc *adc = iio_priv(indio_dev);
        struct device *dev = indio_dev->dev.parent;
        const struct stm32_adc_regspec *regs = adc->cfg->regs;
-       long timeout;
+       long time_left;
        u32 val;
        int ret;
 
@@ -1440,12 +1440,12 @@ static int stm32_adc_single_conv(struct iio_dev *indio_dev,
 
        adc->cfg->start_conv(indio_dev, false);
 
-       timeout = wait_for_completion_interruptible_timeout(
+       time_left = wait_for_completion_interruptible_timeout(
                                        &adc->completion, STM32_ADC_TIMEOUT);
-       if (timeout == 0) {
+       if (time_left == 0) {
                ret = -ETIMEDOUT;
-       } else if (timeout < 0) {
-               ret = timeout;
+       } else if (time_left < 0) {
+               ret = time_left;
        } else {
                *res = adc->buffer[0];
                ret = IIO_VAL_INT;