scsi: hisi_sas: Modify the file permissions of trigger_dump to write only
authorLuo Jiaxing <luojiaxing@huawei.com>
Mon, 20 Jan 2020 12:22:34 +0000 (20:22 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 21 Jan 2020 00:31:14 +0000 (19:31 -0500)
The trigger_dump file is only used to manually trigger the dump, and did
not provide a read callback function for it, so its file permission
setting to 600 is wrong,and should be changed to 200.

Link: https://lore.kernel.org/r/1579522957-4393-5-git-send-email-john.garry@huawei.com
Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hisi_sas/hisi_sas_main.c

index 3e103e86e96451c859858d0538ecbcb39c77d078..61db3376b1f9b1b7ac4fb5986692ba66a4e57d1c 100644 (file)
@@ -3930,7 +3930,7 @@ void hisi_sas_debugfs_init(struct hisi_hba *hisi_hba)
 
        hisi_hba->debugfs_dir = debugfs_create_dir(dev_name(dev),
                                                   hisi_sas_debugfs_dir);
-       debugfs_create_file("trigger_dump", 0600,
+       debugfs_create_file("trigger_dump", 0200,
                            hisi_hba->debugfs_dir,
                            hisi_hba,
                            &hisi_sas_debugfs_trigger_dump_fops);