net: dsa: qca8k: check the correct variable in qca8k_set_mac_eee()

This code check "reg" but "ret" was intended so the error handling will
never trigger.

Fixes: 7c9896e37807 ("net: dsa: qca8k: check return value of read functions correctly")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index 9df3514d1ff26eb493d1e7e644212a82aafa38eb..1f63f50f73f1733558b7867752d13b6d13a2b7c8 100644 (file)
--- a/drivers/net/dsa/qca8k.c
+++ b/drivers/net/dsa/qca8k.c
@@ -1454,10 +1454,8 @@ qca8k_set_mac_eee(struct dsa_switch *ds, int port, struct ethtool_eee *eee)
 
        mutex_lock(&priv->reg_mutex);
        ret = qca8k_read(priv, QCA8K_REG_EEE_CTRL, &reg);
-       if (reg < 0) {
-               ret = reg;
+       if (ret < 0)
                goto exit;
-       }
 
        if (eee->eee_enabled)
                reg |= lpi_en;