migration/colo: Tidy up bql_unlock() around bdrv_activate_all()
authorLi Zhijian <lizhijian@fujitsu.com>
Thu, 16 May 2024 03:45:17 +0000 (11:45 +0800)
committerFabiano Rosas <farosas@suse.de>
Wed, 22 May 2024 20:34:36 +0000 (17:34 -0300)
Make the code more tight.

Suggested-by: Michael Tokarev <mjt@tls.msk.ru>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
[fixed mangled author email address]
Signed-off-by: Fabiano Rosas <farosas@suse.de>
migration/colo.c

index ca37b932acaeac19e4c3797a892b80efa1597732..f96c2ee069ea6db55fc9063e8bfb1d43e7be3040 100644 (file)
@@ -837,12 +837,11 @@ static void *colo_process_incoming_thread(void *opaque)
     /* Make sure all file formats throw away their mutable metadata */
     bql_lock();
     bdrv_activate_all(&local_err);
+    bql_unlock();
     if (local_err) {
-        bql_unlock();
         error_report_err(local_err);
         return NULL;
     }
-    bql_unlock();
 
     failover_init_state();