leds: lgm-sso: Convert to use list_for_each_entry*() API
authorAndy Shevchenko <andy.shevchenko@gmail.com>
Sat, 29 May 2021 11:19:29 +0000 (14:19 +0300)
committerPavel Machek <pavel@ucw.cz>
Tue, 3 Aug 2021 21:46:12 +0000 (23:46 +0200)
Convert to use list_for_each_entry*() API insted of open coded variants.
It saves few lines of code and makes iteasier to read and maintain.

Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/blink/leds-lgm-sso.c

index 5c012ffeeaa855dd6d4549f45f6ec6e7de0f910c..e47c47e421d6106797f9d4af2d625c0ccf2d023a 100644 (file)
@@ -621,7 +621,6 @@ __sso_led_dt_parse(struct sso_led_priv *priv, struct fwnode_handle *fw_ssoled)
        struct device *dev = priv->dev;
        struct sso_led_desc *desc;
        struct sso_led *led;
-       struct list_head *p;
        const char *tmp;
        u32 prop;
        int ret;
@@ -707,10 +706,8 @@ __sso_led_dt_parse(struct sso_led_priv *priv, struct fwnode_handle *fw_ssoled)
 __dt_err:
        fwnode_handle_put(fwnode_child);
        /* unregister leds */
-       list_for_each(p, &priv->led_list) {
-               led = list_entry(p, struct sso_led, list);
+       list_for_each_entry(led, &priv->led_list, list)
                sso_led_shutdown(led);
-       }
 
        return -EINVAL;
 }
@@ -841,14 +838,12 @@ static int intel_sso_led_probe(struct platform_device *pdev)
 static int intel_sso_led_remove(struct platform_device *pdev)
 {
        struct sso_led_priv *priv;
-       struct list_head *pos, *n;
-       struct sso_led *led;
+       struct sso_led *led, *n;
 
        priv = platform_get_drvdata(pdev);
 
-       list_for_each_safe(pos, n, &priv->led_list) {
-               list_del(pos);
-               led = list_entry(pos, struct sso_led, list);
+       list_for_each_entry_safe(led, n, &priv->led_list, list) {
+               list_del(&led->list);
                sso_led_shutdown(led);
        }