ASoC: Intel: sof_rt5682: remove hdac-hdmi support

Remove hdac-hdmi support code since we are now using
snd-hda-codec-hdmi codec driver for hdmi.

Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: Brent Lu <brent.lu@intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20231012190826.142619-11-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig
index b5f3887e03239eadbc570abed05abace7ece3328..38cb494e3ca0fff832fa81b110445b503e8474a7 100644 (file)
--- a/sound/soc/intel/boards/Kconfig
+++ b/sound/soc/intel/boards/Kconfig
@@ -495,7 +495,6 @@ config SND_SOC_INTEL_SOF_RT5682_MACH
        select SND_SOC_RT5682_I2C
        select SND_SOC_RT5682S
        select SND_SOC_DMIC
-       select SND_SOC_HDAC_HDMI
        select SND_SOC_INTEL_HDA_DSP_COMMON
        select SND_SOC_INTEL_SOF_MAXIM_COMMON
        select SND_SOC_INTEL_SOF_REALTEK_COMMON

diff --git a/sound/soc/intel/boards/sof_rt5682.c b/sound/soc/intel/boards/sof_rt5682.c
index 991763efb7d27cecb1505428affc0fc28a951a33..e256430b65a8d3af3c0742934fde8346b6fdd77d 100644 (file)
--- a/sound/soc/intel/boards/sof_rt5682.c
+++ b/sound/soc/intel/boards/sof_rt5682.c
@@ -23,15 +23,12 @@
 #include "../../codecs/rt5682.h"
 #include "../../codecs/rt5682s.h"
 #include "../../codecs/rt5645.h"
-#include "../../codecs/hdac_hdmi.h"
 #include "../common/soc-intel-quirks.h"
 #include "hda_dsp_common.h"
 #include "sof_maxim_common.h"
 #include "sof_realtek_common.h"
 #include "sof_ssp_common.h"
 
-#define NAME_SIZE 32
-
 #define SOF_RT5682_SSP_CODEC(quirk)            ((quirk) & GENMASK(2, 0))
 #define SOF_RT5682_SSP_CODEC_MASK                      (GENMASK(2, 0))
 #define SOF_RT5682_MCLK_EN                     BIT(3)
@@ -67,15 +64,12 @@ static int is_legacy_cpu;
 struct sof_hdmi_pcm {
        struct list_head head;
        struct snd_soc_dai *codec_dai;
-       struct snd_soc_jack hdmi_jack;
-       int device;
 };
 
 struct sof_card_private {
        struct clk *mclk;
        struct snd_soc_jack sof_headset;
        struct list_head hdmi_pcm_list;
-       bool common_hdmi_codec_drv;
        bool idisp_codec;
        enum sof_ssp_codec codec_type;
        enum sof_ssp_codec amp_type;
@@ -242,8 +236,6 @@ static int sof_hdmi_init(struct snd_soc_pcm_runtime *rtd)
        if (!pcm)
                return -ENOMEM;
 
-       /* dai_link id is 1:1 mapped to the PCM device */
-       pcm->device = rtd->dai_link->id;
        pcm->codec_dai = dai;
 
        list_add_tail(&pcm->head, &ctx->hdmi_pcm_list);
@@ -518,7 +510,6 @@ static int sof_card_late_probe(struct snd_soc_card *card)
        struct sof_card_private *ctx = snd_soc_card_get_drvdata(card);
        struct snd_soc_component *component = NULL;
        struct snd_soc_dapm_context *dapm = &card->dapm;
-       char jack_name[NAME_SIZE];
        struct sof_hdmi_pcm *pcm;
        int err;
 
@@ -538,30 +529,9 @@ static int sof_card_late_probe(struct snd_soc_card *card)
        if (list_empty(&ctx->hdmi_pcm_list))
                return -EINVAL;
 
-       if (ctx->common_hdmi_codec_drv) {
-               pcm = list_first_entry(&ctx->hdmi_pcm_list, struct sof_hdmi_pcm,
-                                      head);
-               component = pcm->codec_dai->component;
-               return hda_dsp_hdmi_build_controls(card, component);
-       }
-
-       list_for_each_entry(pcm, &ctx->hdmi_pcm_list, head) {
-               component = pcm->codec_dai->component;
-               snprintf(jack_name, sizeof(jack_name),
-                        "HDMI/DP, pcm=%d Jack", pcm->device);
-               err = snd_soc_card_jack_new(card, jack_name,
-                                           SND_JACK_AVOUT, &pcm->hdmi_jack);
-
-               if (err)
-                       return err;
-
-               err = hdac_hdmi_jack_init(pcm->codec_dai, pcm->device,
-                                         &pcm->hdmi_jack);
-               if (err < 0)
-                       return err;
-       }
-
-       return hdac_hdmi_jack_port_init(component, &card->dapm);
+       pcm = list_first_entry(&ctx->hdmi_pcm_list, struct sof_hdmi_pcm, head);
+       component = pcm->codec_dai->component;
+       return hda_dsp_hdmi_build_controls(card, component);
 }
 
 static const struct snd_kcontrol_new sof_controls[] = {
@@ -834,7 +804,7 @@ sof_card_dai_links_create(struct device *dev, enum sof_ssp_codec codec_type,
                links[id].num_codecs = 1;
                links[id].platforms = platform_component;
                links[id].num_platforms = ARRAY_SIZE(platform_component);
-               links[id].init = sof_hdmi_init;
+               links[id].init = (i == 1) ? sof_hdmi_init : NULL;
                links[id].dpcm_playback = 1;
                links[id].no_pcm = 1;
                id++;
@@ -974,8 +944,8 @@ devm_err:
 
 static int sof_audio_probe(struct platform_device *pdev)
 {
+       struct snd_soc_acpi_mach *mach = pdev->dev.platform_data;
        struct snd_soc_dai_link *dai_links;
-       struct snd_soc_acpi_mach *mach;
        struct sof_card_private *ctx;
        int dmic_be_num, hdmi_num;
        int ret, ssp_amp, ssp_codec;
@@ -989,8 +959,6 @@ static int sof_audio_probe(struct platform_device *pdev)
 
        dmi_check_system(sof_rt5682_quirk_table);
 
-       mach = pdev->dev.platform_data;
-
        ctx->codec_type = sof_ssp_detect_codec_type(&pdev->dev);
        ctx->amp_type = sof_ssp_detect_amp_type(&pdev->dev);
 
@@ -1112,8 +1080,6 @@ static int sof_audio_probe(struct platform_device *pdev)
        if (ret)
                return ret;
 
-       ctx->common_hdmi_codec_drv = mach->mach_params.common_hdmi_codec_drv;
-
        snd_soc_card_set_drvdata(&sof_audio_card_rt5682, ctx);
 
        return devm_snd_soc_register_card(&pdev->dev,