btrfs: don't check PageError in __extent_writepage

__extent_writepage currenly sets PageError whenever any error happens,
and the also checks for PageError to decide if to call error handling.
This leads to very unclear responsibility for cleaning up on errors.
In the VM and generic writeback helpers the basic idea is that once
I/O is fired off all error handling responsibility is delegated to the
end I/O handler.  But if that end I/O handler sets the PageError bit,
and the submitter checks it, the bit could in some cases leak into the
submission context for fast enough I/O.

Fix this by simply not checking PageError and just using the local
ret variable to check for submission errors.  This also fundamentally
solves the long problem documented in a comment in __extent_writepage
by never leaking the error bit into the submission context.

Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index 178e8230c28af92ba383a8b9d7e0777f203c2535..33e5f0a31c21a7ddd7d105eca3461f03ae41e58a 100644 (file)
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -1557,38 +1557,7 @@ done:
                set_page_writeback(page);
                end_page_writeback(page);
        }
-       /*
-        * Here we used to have a check for PageError() and then set @ret and
-        * call end_extent_writepage().
-        *
-        * But in fact setting @ret here will cause different error paths
-        * between subpage and regular sectorsize.
-        *
-        * For regular page size, we never submit current page, but only add
-        * current page to current bio.
-        * The bio submission can only happen in next page.
-        * Thus if we hit the PageError() branch, @ret is already set to
-        * non-zero value and will not get updated for regular sectorsize.
-        *
-        * But for subpage case, it's possible we submit part of current page,
-        * thus can get PageError() set by submitted bio of the same page,
-        * while our @ret is still 0.
-        *
-        * So here we unify the behavior and don't set @ret.
-        * Error can still be properly passed to higher layer as page will
-        * be set error, here we just don't handle the IO failure.
-        *
-        * NOTE: This is just a hotfix for subpage.
-        * The root fix will be properly ending ordered extent when we hit
-        * an error during writeback.
-        *
-        * But that needs a bigger refactoring, as we not only need to grab the
-        * submitted OE, but also need to know exactly at which bytenr we hit
-        * the error.
-        * Currently the full page based __extent_writepage_io() is not
-        * capable of that.
-        */
-       if (PageError(page))
+       if (ret)
                end_extent_writepage(page, ret, page_start, page_end);
        if (bio_ctrl->extent_locked) {
                struct writeback_control *wbc = bio_ctrl->wbc;