PCI: qcom: Use __be16 type to store return value from cpu_to_be16()
authorManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Tue, 30 Nov 2021 08:09:24 +0000 (13:39 +0530)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Mon, 6 Dec 2021 10:29:43 +0000 (10:29 +0000)
cpu_to_be16() returns __be16 value but the driver uses u16 and that's
incorrect. Fix it by using __be16 as the data type of bdf_be variable.

The issue was spotted by the below sparse warning:

sparse warnings: (new ones prefixed by >>)
>> drivers/pci/controller/dwc/pcie-qcom.c:1305:30: sparse: sparse: incorrect type in initializer (different base types) @@     expected unsigned short [usertype] bdf_be @@     got restricted __be16 [usertype] @@
   drivers/pci/controller/dwc/pcie-qcom.c:1305:30: sparse:     expected unsigned short [usertype] bdf_be
   drivers/pci/controller/dwc/pcie-qcom.c:1305:30: sparse:     got restricted __be16 [usertype]

Link: https://lore.kernel.org/r/20211130080924.266116-1-manivannan.sadhasivam@linaro.org
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Krzysztof WilczyƄski <kw@linux.com>
drivers/pci/controller/dwc/pcie-qcom.c

index baae67f71ba825bf6fd2373056cb1037220f3633..c19cd506ed3f2315312431ca5b9dcf015a4be5f0 100644 (file)
@@ -1343,7 +1343,7 @@ static int qcom_pcie_config_sid_sm8250(struct qcom_pcie *pcie)
 
        /* Look for an available entry to hold the mapping */
        for (i = 0; i < nr_map; i++) {
-               u16 bdf_be = cpu_to_be16(map[i].bdf);
+               __be16 bdf_be = cpu_to_be16(map[i].bdf);
                u32 val;
                u8 hash;