util/vfio-helpers: Remove unreachable code in qemu_vfio_dma_map()
authorPhilippe Mathieu-Daudé <philmd@redhat.com>
Thu, 2 Sep 2021 07:00:18 +0000 (09:00 +0200)
committerStefan Hajnoczi <stefanha@redhat.com>
Tue, 7 Sep 2021 08:08:24 +0000 (09:08 +0100)
qemu_vfio_add_mapping() returns a pointer to an indexed entry
in pre-allocated QEMUVFIOState::mappings[], thus can not be NULL.
Remove the pointless check.

Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20210902070025.197072-5-philmd@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
util/vfio-helpers.c

index d956866b4e98e0e01007cc0e654f71aa952a8759..e7909222cfdf885314a0cdedeeaa6ae64f2b2a9a 100644 (file)
@@ -751,10 +751,6 @@ int qemu_vfio_dma_map(QEMUVFIOState *s, void *host, size_t size,
             }
 
             mapping = qemu_vfio_add_mapping(s, host, size, index + 1, iova0);
-            if (!mapping) {
-                ret = -ENOMEM;
-                goto out;
-            }
             assert(qemu_vfio_verify_mappings(s));
             ret = qemu_vfio_do_mapping(s, host, size, iova0);
             if (ret) {