wifi: ath10k: Annotate struct ath10k_ce_ring with __counted_by
authorKees Cook <keescook@chromium.org>
Fri, 15 Sep 2023 20:06:36 +0000 (13:06 -0700)
committerKalle Valo <quic_kvalo@quicinc.com>
Thu, 21 Sep 2023 08:10:17 +0000 (11:10 +0300)
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct ath10k_ce_ring.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Cc: Kalle Valo <kvalo@kernel.org>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230915200636.never.762-kees@kernel.org
drivers/net/wireless/ath/ath10k/ce.h

index 666ce384a1d8bcbd395dca176a54dedd62de80b3..27367bd64e957790fff8af63ae98cc447bdda194 100644 (file)
@@ -110,7 +110,7 @@ struct ath10k_ce_ring {
        struct ce_desc_64 *shadow_base;
 
        /* keep last */
-       void *per_transfer_context[];
+       void *per_transfer_context[] __counted_by(nentries);
 };
 
 struct ath10k_ce_pipe {