projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
99aebb3
)
spi: fsl-spi: No need to check transfer length versus word size
author
Christophe Leroy
<christophe.leroy@csgroup.eu>
Sat, 1 Apr 2023 17:59:50 +0000
(19:59 +0200)
committer
Mark Brown
<broonie@kernel.org>
Wed, 5 Apr 2023 11:33:36 +0000
(12:33 +0100)
The verification is already do in the SPI core by function
__spi_validate(), not it to check it again in fsl_spi_bufs().
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Link:
https://lore.kernel.org/r/9ace69a8085e22fafd9159e99edd7bbfae2f9940.1680371809.git.christophe.leroy@csgroup.eu
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-fsl-spi.c
patch
|
blob
|
history
diff --git
a/drivers/spi/spi-fsl-spi.c
b/drivers/spi/spi-fsl-spi.c
index e64c5f5452d03cf2a8da6382e7dd7247001c81d2..106fe60a0a50bf604b64a5ccb64a4216b5901918 100644
(file)
--- a/
drivers/spi/spi-fsl-spi.c
+++ b/
drivers/spi/spi-fsl-spi.c
@@
-263,18
+263,10
@@
static int fsl_spi_bufs(struct spi_device *spi, struct spi_transfer *t,
if (t->bits_per_word)
bits_per_word = t->bits_per_word;
- if (bits_per_word > 8) {
- /* invalid length? */
- if (len & 1)
- return -EINVAL;
+ if (bits_per_word > 8)
len /= 2;
- }
- if (bits_per_word > 16) {
- /* invalid length? */
- if (len & 1)
- return -EINVAL;
+ if (bits_per_word > 16)
len /= 2;
- }
mpc8xxx_spi->tx = t->tx_buf;
mpc8xxx_spi->rx = t->rx_buf;