usb: host: ohci-ppc-of: Fix refcount leak bug
authorLiang He <windhl@126.com>
Fri, 17 Jun 2022 03:46:37 +0000 (11:46 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 21 Jun 2022 14:38:53 +0000 (16:38 +0200)
In ohci_hcd_ppc_of_probe(), of_find_compatible_node() will return
a node pointer with refcount incremented. We should use of_node_put()
when it is not used anymore.

Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220617034637.4003115-1-windhl@126.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ohci-ppc-of.c

index 1960b8dfdba511253e0ebd72d4fc74588ddffc1d..591f675cc9306ffc879478fcc2e56c4d7ed286f4 100644 (file)
@@ -166,6 +166,7 @@ static int ohci_hcd_ppc_of_probe(struct platform_device *op)
                                release_mem_region(res.start, 0x4);
                } else
                        pr_debug("%s: cannot get ehci offset from fdt\n", __FILE__);
+               of_node_put(np);
        }
 
        irq_dispose_mapping(irq);