scsi: lpfc: Fix a precedence bug in lpfc_nvme_io_cmd_wqe_cmpl()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 12 Oct 2017 20:30:57 +0000 (23:30 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 17 Oct 2017 02:43:54 +0000 (22:43 -0400)
The ! has higher precedence than the & operation.  I've added
parenthesis so this works as intended.

Fixes: 952c303b329c ("scsi: lpfc: Ensure io aborts interlocked with the target.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_nvme.c

index ea2a41022ace87f29a3acea1aaf8c6631362706d..db1ed426f7e60fddccc9b86fe28ceecde3109cdc 100644 (file)
@@ -948,7 +948,7 @@ out_err:
        /* NVME targets need completion held off until the abort exchange
         * completes.
         */
-       if (!lpfc_ncmd->flags & LPFC_SBUF_XBUSY)
+       if (!(lpfc_ncmd->flags & LPFC_SBUF_XBUSY))
                nCmd->done(nCmd);
 
        spin_lock_irqsave(&phba->hbalock, flags);