scsi: myrs: Fix uninitialized variable
authorYueHaibing <yuehaibing@huawei.com>
Thu, 9 May 2019 15:22:47 +0000 (23:22 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 20 May 2019 14:56:43 +0000 (10:56 -0400)
drivers/scsi/myrs.c: In function 'myrs_log_event':
drivers/scsi/myrs.c:821:24: warning: 'sshdr.sense_key' may be used uninitialized in this function [-Wmaybe-uninitialized]
  struct scsi_sense_hdr sshdr;

If ev->ev_code is not 0x1C, sshdr.sense_key may be used uninitialized. Fix
this by initializing variable 'sshdr' to 0.

Fixes: 77266186397c ("scsi: myrs: Add Mylex RAID controller (SCSI interface)")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/myrs.c

index b8d54ef8cf6dfb84c6d4cb3ce2714071cc2de1d6..eb0dd566330abdab242b3953b7641f60a0342ce3 100644 (file)
@@ -818,7 +818,7 @@ static void myrs_log_event(struct myrs_hba *cs, struct myrs_event *ev)
        unsigned char ev_type, *ev_msg;
        struct Scsi_Host *shost = cs->host;
        struct scsi_device *sdev;
-       struct scsi_sense_hdr sshdr;
+       struct scsi_sense_hdr sshdr = {0};
        unsigned char sense_info[4];
        unsigned char cmd_specific[4];