drm/amdgpu/powerplay: fix return codes in BACO code

Use a proper return code rather than -1.

Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_baco.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_baco.c
index d5232110ec84a2da3e9748bdd8e5174673763d7b..7337be5602e4bea84885e18fa98f66b3e7026874 100644 (file)
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_baco.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_baco.c
@@ -136,7 +136,7 @@ int vega10_baco_set_state(struct pp_hwmgr *hwmgr, enum BACO_STATE state)
                if (soc15_baco_program_registers(hwmgr, pre_baco_tbl,
                                             ARRAY_SIZE(pre_baco_tbl))) {
                        if (smum_send_msg_to_smc(hwmgr, PPSMC_MSG_EnterBaco))
-                               return -1;
+                               return -EINVAL;
 
                        if (soc15_baco_program_registers(hwmgr, enter_baco_tbl,
                                                   ARRAY_SIZE(enter_baco_tbl)))
@@ -154,5 +154,5 @@ int vega10_baco_set_state(struct pp_hwmgr *hwmgr, enum BACO_STATE state)
                }
        }
 
-       return -1;
+       return -EINVAL;
 }

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_baco.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_baco.c
index edf00da8424b1ab660c4c18b7941b11fd9423662..5e8602a79b1c30d0a63bd97e7485740884e1a875 100644 (file)
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_baco.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_baco.c
@@ -89,14 +89,14 @@ int vega20_baco_set_state(struct pp_hwmgr *hwmgr, enum BACO_STATE state)
 
 
                if(smum_send_msg_to_smc_with_parameter(hwmgr, PPSMC_MSG_EnterBaco, 0))
-                       return -1;
+                       return -EINVAL;
 
        } else if (state == BACO_STATE_OUT) {
                if (smum_send_msg_to_smc(hwmgr, PPSMC_MSG_ExitBaco))
-                       return -1;
+                       return -EINVAL;
                if (!soc15_baco_program_registers(hwmgr, clean_baco_tbl,
                                                     ARRAY_SIZE(clean_baco_tbl)))
-                       return -1;
+                       return -EINVAL;
        }
 
        return 0;