platform/x86: wmi: Remove unused variable in address space handler
authorArmin Wolf <W_Armin@gmx.de>
Mon, 18 Dec 2023 19:24:15 +0000 (20:24 +0100)
committerHans de Goede <hdegoede@redhat.com>
Tue, 19 Dec 2023 15:32:46 +0000 (16:32 +0100)
The variable "i" is always zero and only used in shift operations.
Remove it to make the code more readable.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Link: https://lore.kernel.org/r/20231218192420.305411-2-W_Armin@gmx.de
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/wmi.c

index 7303702290e5ed4e48fd31f9d17cd09ddec72c7b..906d3a2831ae200083da8b26c36f8befe4c94417 100644 (file)
@@ -1144,7 +1144,7 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physical_address address,
                          u32 bits, u64 *value,
                          void *handler_context, void *region_context)
 {
-       int result = 0, i = 0;
+       int result = 0;
        u8 temp = 0;
 
        if ((address > 0xFF) || !value)
@@ -1158,9 +1158,9 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physical_address address,
 
        if (function == ACPI_READ) {
                result = ec_read(address, &temp);
-               (*value) |= ((u64)temp) << i;
+               *value = temp;
        } else {
-               temp = 0xff & ((*value) >> i);
+               temp = 0xff & *value;
                result = ec_write(address, temp);
        }