spi/panel: dt-bindings: drop 3-wire from common properties
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 10 Aug 2022 13:13:11 +0000 (16:13 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 15 Aug 2022 11:18:43 +0000 (12:18 +0100)
The spi-3wire property is device specific and should be accepted only if
device really needs them.  Drop it from common spi-peripheral-props.yaml
schema, mention in few panel drivers which use it and include instead in
the SPI controller bindings.  The controller bindings will provide
spi-3wire type validation and one place for description.  Each device
schema must list the property if it is applicable.

The Samsung S6E63M0 panel uses also spi-cpha/cpol properties on at least
one board (ste-ux500-samsung-janice/dts), so add also these to the
panel's bindings.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20220810131311.428645-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml
Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t.yaml
Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml
Documentation/devicetree/bindings/spi/spi-controller.yaml
Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml

index 2a2756d196810e6489ef2cd912d0fc361ee61fd2..b4be9bd8ddde7c681895894689d03c3e4f855ed9 100644 (file)
@@ -23,6 +23,8 @@ properties:
   reg: true
   reset-gpios: true
 
+  spi-3wire: true
+
 required:
   - compatible
   - power-supply
index 817a9bed7d5a88e5586b60eb9824d62b5c8484a1..ebdca5f5a00117299833abf8e535ce965139c19a 100644 (file)
@@ -24,6 +24,8 @@ properties:
   reg: true
   reset-gpios: true
 
+  spi-3wire: true
+
 required:
   - compatible
   - power-supply
index 940f7f88526ff9796a9540f566609781e6248722..6f1fc7469f076f68432b16c39341612c16326261 100644 (file)
@@ -24,6 +24,10 @@ properties:
   default-brightness: true
   max-brightness: true
 
+  spi-3wire: true
+  spi-cpha: true
+  spi-cpol: true
+
   vdd3-supply:
     description: VDD regulator
 
index 655713fba7e252354eb6c1b67f9018b916d439c6..01042a7f382e2b6f22d995333e161aa81ff5d6f2 100644 (file)
@@ -96,6 +96,11 @@ patternProperties:
     $ref: spi-peripheral-props.yaml
 
     properties:
+      spi-3wire:
+        $ref: /schemas/types.yaml#/definitions/flag
+        description:
+          The device requires 3-wire mode.
+
       spi-cpha:
         $ref: /schemas/types.yaml#/definitions/flag
         description:
index a4abe15880053419cb0926330c5955d4cbf8e529..dca677f9e1b98f44b2525deddc04d1488d5f7797 100644 (file)
@@ -29,11 +29,6 @@ properties:
     description:
       Chip select used by the device.
 
-  spi-3wire:
-    $ref: /schemas/types.yaml#/definitions/flag
-    description:
-      The device requires 3-wire mode.
-
   spi-cs-high:
     $ref: /schemas/types.yaml#/definitions/flag
     description: