x86/head: Mark *_start_kernel() __noreturn
authorJosh Poimboeuf <jpoimboe@kernel.org>
Wed, 12 Apr 2023 23:49:33 +0000 (16:49 -0700)
committerPeter Zijlstra <peterz@infradead.org>
Fri, 14 Apr 2023 15:31:24 +0000 (17:31 +0200)
Now that start_kernel() is __noreturn, mark its chain of callers
__noreturn.

Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/c2525f96b88be98ee027ee0291d58003036d4120.1681342859.git.jpoimboe@kernel.org
arch/x86/include/asm/setup.h
arch/x86/kernel/head32.c
arch/x86/kernel/head64.c
tools/objtool/check.c

index f37cbff7354c49e211e51743f1b229286dae656d..f3495623ac997222fe62a9b571c656b6fcbc7fbb 100644 (file)
@@ -125,11 +125,11 @@ void clear_bss(void);
 
 #ifdef __i386__
 
-asmlinkage void __init i386_start_kernel(void);
+asmlinkage void __init __noreturn i386_start_kernel(void);
 
 #else
-asmlinkage void __init x86_64_start_kernel(char *real_mode);
-asmlinkage void __init x86_64_start_reservations(char *real_mode_data);
+asmlinkage void __init __noreturn x86_64_start_kernel(char *real_mode);
+asmlinkage void __init __noreturn x86_64_start_reservations(char *real_mode_data);
 
 #endif /* __i386__ */
 #endif /* _SETUP */
index ec6fefbfd3c0454b009a2a7a04a76edc44b8c5e8..10c27b4261eb0b969e6360c9acffe4358ff4adb0 100644 (file)
@@ -29,7 +29,7 @@ static void __init i386_default_early_setup(void)
        x86_init.mpparse.setup_ioapic_ids = setup_ioapic_ids_from_mpc;
 }
 
-asmlinkage __visible void __init i386_start_kernel(void)
+asmlinkage __visible void __init __noreturn i386_start_kernel(void)
 {
        /* Make sure IDT is set up before any exception happens */
        idt_setup_early_handler();
index 387e4b12e823a5b472e41f7755f397494c9d26d8..49f7629b17f734fd1407d009578566659d1d8edb 100644 (file)
@@ -471,7 +471,7 @@ static void __init copy_bootdata(char *real_mode_data)
        sme_unmap_bootdata(real_mode_data);
 }
 
-asmlinkage __visible void __init x86_64_start_kernel(char * real_mode_data)
+asmlinkage __visible void __init __noreturn x86_64_start_kernel(char * real_mode_data)
 {
        /*
         * Build-time sanity checks on the kernel image and module
@@ -537,7 +537,7 @@ asmlinkage __visible void __init x86_64_start_kernel(char * real_mode_data)
        x86_64_start_reservations(real_mode_data);
 }
 
-void __init x86_64_start_reservations(char *real_mode_data)
+void __init __noreturn x86_64_start_reservations(char *real_mode_data)
 {
        /* version is always not zero if it is copied */
        if (!boot_params.hdr.version)
index 9aaad9dc6c208df75227caca2ff03f88dea6ba1e..a436bc1e63d92c8827ae735eee9094b8a0b0861f 100644 (file)
@@ -225,6 +225,8 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func,
                "start_kernel",
                "stop_this_cpu",
                "usercopy_abort",
+               "x86_64_start_kernel",
+               "x86_64_start_reservations",
                "xen_cpu_bringup_again",
                "xen_start_kernel",
        };