pinctrl: ralink: rt2880: delete not needed error message
authorSergio Paracuellos <sergio.paracuellos@gmail.com>
Sun, 13 Dec 2020 16:17:18 +0000 (17:17 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 4 Jan 2021 14:38:34 +0000 (15:38 +0100)
When '-ENOMEM' is returned there is not need at all to
add custom error messages. Hence delete it.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20201213161721.6514-6-sergio.paracuellos@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/ralink/pinctrl-rt2880.c

index 3c3336b724caea012b47868181f6ed347346bb42..4725aa34328aa1cc22b1ded578bd6359922445b3 100644 (file)
@@ -279,10 +279,8 @@ static int rt2880_pinmux_pins(struct rt2880_priv *p)
        /* the pads needed to tell pinctrl about our pins */
        p->pads = devm_kcalloc(p->dev, p->max_pins,
                               sizeof(struct pinctrl_pin_desc), GFP_KERNEL);
-       if (!p->pads || !p->gpio) {
-               dev_err(p->dev, "Failed to allocate gpio data\n");
+       if (!p->pads || !p->gpio)
                return -ENOMEM;
-       }
 
        memset(p->gpio, 1, sizeof(u8) * p->max_pins);
        for (i = 0; i < p->func_count; i++) {