i2c: synquacer: use 'time_left' variable with wait_for_completion_timeout()
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Sat, 27 Apr 2024 20:36:02 +0000 (22:36 +0200)
committerAndi Shyti <andi.shyti@kernel.org>
Sun, 5 May 2024 22:56:53 +0000 (00:56 +0200)
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:

timeout = wait_for_completion_timeout(...)
if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-synquacer.c

index bbea521b05dda7461736487ad3837aede5589ea4..bf9bcfefa30e31f0484f4c92ff1fdd9af9d17f04 100644 (file)
@@ -311,7 +311,7 @@ static int synquacer_i2c_doxfer(struct synquacer_i2c *i2c,
                                struct i2c_msg *msgs, int num)
 {
        unsigned char bsr;
-       unsigned long timeout;
+       unsigned long time_left;
        int ret;
 
        synquacer_i2c_hw_init(i2c);
@@ -335,9 +335,9 @@ static int synquacer_i2c_doxfer(struct synquacer_i2c *i2c,
                return ret;
        }
 
-       timeout = wait_for_completion_timeout(&i2c->completion,
-                                       msecs_to_jiffies(i2c->timeout_ms));
-       if (timeout == 0) {
+       time_left = wait_for_completion_timeout(&i2c->completion,
+                                               msecs_to_jiffies(i2c->timeout_ms));
+       if (time_left == 0) {
                dev_dbg(i2c->dev, "timeout\n");
                return -EAGAIN;
        }