chardev: unref if underlying chardev has no parent
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Wed, 11 Jul 2018 18:00:19 +0000 (20:00 +0200)
committerMarc-André Lureau <marcandre.lureau@redhat.com>
Wed, 3 Oct 2018 10:45:04 +0000 (14:45 +0400)
It's possible to write code creating a chardev backend that is not
registered. When it is not user-created, it makes sense to keep it
hidden. Let the associated frontend destroy it also in this case.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
chardev/char-fe.c

index f158f158f818c29f9ccca19c4766951105d650d3..a8931f7afd2e4141521c35269f2864be73c3dc01 100644 (file)
@@ -235,7 +235,12 @@ void qemu_chr_fe_deinit(CharBackend *b, bool del)
             d->backends[b->tag] = NULL;
         }
         if (del) {
-            object_unparent(OBJECT(b->chr));
+            Object *obj = OBJECT(b->chr);
+            if (obj->parent) {
+                object_unparent(obj);
+            } else {
+                object_unref(obj);
+            }
         }
         b->chr = NULL;
     }