spi: spidev: fix speed setting message

The message of max device speed setting is shown when
an error in spi_setup() occurs.
Instead, it should be shown when the setup call succeeds.

Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Link: https://lore.kernel.org/r/20200229161841.89144-3-oleksandr.suvorov@toradex.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index c97e853dbf5c14249f381c3c3d62aa8e90a58129..80dd1025b95304932ca5a8c6ca2c4fe468eb755b 100644 (file)
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -454,10 +454,11 @@ spidev_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 
                        spi->max_speed_hz = tmp;
                        retval = spi_setup(spi);
-                       if (retval >= 0)
+                       if (retval == 0) {
                                spidev->speed_hz = tmp;
-                       else
-                               dev_dbg(&spi->dev, "%d Hz (max)\n", tmp);
+                               dev_dbg(&spi->dev, "%d Hz (max)\n",
+                                       spidev->speed_hz);
+                       }
                        spi->max_speed_hz = save;
                }
                break;