HSI: omap_ssi_port: Drop error checking for debugfs_create_dir

This patch fixes the error checking in omap_ssi_port.c. The DebugFS
kernel API is developed in a way that the caller can safely ignore the
errors that occur during the creation of DebugFS nodes.

Signed-off-by: Osama Muhammad <osmtendev@gmail.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

diff --git a/drivers/hsi/controllers/omap_ssi_port.c b/drivers/hsi/controllers/omap_ssi_port.c
index b9495b720f1bd121970deaf4f151a517c27b33d4..c78d9c9f73712c9e8bfee0718115eb87fdacf509 100644 (file)
--- a/drivers/hsi/controllers/omap_ssi_port.c
+++ b/drivers/hsi/controllers/omap_ssi_port.c
@@ -151,23 +151,17 @@ static int ssi_div_set(void *data, u64 val)
 
 DEFINE_DEBUGFS_ATTRIBUTE(ssi_sst_div_fops, ssi_div_get, ssi_div_set, "%llu\n");
 
-static int ssi_debug_add_port(struct omap_ssi_port *omap_port,
+static void ssi_debug_add_port(struct omap_ssi_port *omap_port,
                                     struct dentry *dir)
 {
        struct hsi_port *port = to_hsi_port(omap_port->dev);
 
        dir = debugfs_create_dir(dev_name(omap_port->dev), dir);
-       if (!dir)
-               return -ENOMEM;
        omap_port->dir = dir;
        debugfs_create_file("regs", S_IRUGO, dir, port, &ssi_port_regs_fops);
        dir = debugfs_create_dir("sst", dir);
-       if (!dir)
-               return -ENOMEM;
        debugfs_create_file_unsafe("divisor", 0644, dir, port,
                                   &ssi_sst_div_fops);
-
-       return 0;
 }
 #endif
 
@@ -1217,11 +1211,7 @@ static int ssi_port_probe(struct platform_device *pd)
        pm_runtime_enable(omap_port->pdev);
 
 #ifdef CONFIG_DEBUG_FS
-       err = ssi_debug_add_port(omap_port, omap_ssi->dir);
-       if (err < 0) {
-               pm_runtime_disable(omap_port->pdev);
-               goto error;
-       }
+       ssi_debug_add_port(omap_port, omap_ssi->dir);
 #endif
 
        hsi_add_clients_from_dt(port, np);