media: atomisp: Simplify some if (IS_ISP2401...) statements
authorHans de Goede <hdegoede@redhat.com>
Sat, 12 Aug 2023 10:46:12 +0000 (12:46 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Wed, 27 Sep 2023 07:40:04 +0000 (09:40 +0200)
Replace:

 if (!IS_ISP2401 || (IS_ISP2401 && xxx))

with:

 if (!IS_ISP2401 || xxx)

If the right side of the '||' needs to be evaluated then it is
already known that IS_ISP2401 is true, so no need to check for it.

Link: https://lore.kernel.org/r/20230812104612.38806-1-hdegoede@redhat.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/atomisp/pci/sh_css.c

index 81f18db7316c9c46912ae89fb44e3977152a14f6..f35c90809414cb6d5e235e16ebdca5dd3ecb047d 100644 (file)
@@ -7351,7 +7351,7 @@ static int capture_start(struct ia_css_pipe *pipe)
                }
        }
        /* old isys: need to send_mipi_frames() in all pipe modes */
-       if (!IS_ISP2401 || (IS_ISP2401 && pipe->config.mode != IA_CSS_PIPE_MODE_COPY)) {
+       if (!IS_ISP2401 || pipe->config.mode != IA_CSS_PIPE_MODE_COPY) {
                err = send_mipi_frames(pipe);
                if (err) {
                        IA_CSS_LEAVE_ERR_PRIVATE(err);
@@ -8077,7 +8077,7 @@ ia_css_stream_create(const struct ia_css_stream_config *stream_config,
 
        /* check if mipi size specified */
        if (stream_config->mode == IA_CSS_INPUT_MODE_BUFFERED_SENSOR)
-               if (!IS_ISP2401 || (IS_ISP2401 && !stream_config->online))
+               if (!IS_ISP2401 || !stream_config->online)
                {
                        unsigned int port = (unsigned int)stream_config->source.port.port;