staging: rtl8192e: Remove ftrace-like logging in rtl_ps.c
authorPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Sat, 17 Sep 2022 04:25:48 +0000 (06:25 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 24 Sep 2022 10:59:53 +0000 (12:59 +0200)
Remove "Unnecessary ftrace-like logging" as requested by checkpatch.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/6d942ba65f62643af2ff7104911f7947cca21790.1663387785.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl8192e/rtl_ps.c

index 966debd99296548b18d1fe43be3d5ee6fc86b60e..d752bbc310d1cfac3ac3aeefb9d9921e1f8295a8 100644 (file)
@@ -23,13 +23,9 @@ static void _rtl92e_hw_sleep(struct net_device *dev)
        spin_lock_irqsave(&priv->rf_ps_lock, flags);
        if (priv->rf_change_in_progress) {
                spin_unlock_irqrestore(&priv->rf_ps_lock, flags);
-               RT_TRACE(COMP_DBG,
-                        "%s(): RF Change in progress!\n", __func__);
                return;
        }
        spin_unlock_irqrestore(&priv->rf_ps_lock, flags);
-       RT_TRACE(COMP_DBG, "%s()============>come to sleep down\n", __func__);
-
        rtl92e_set_rf_state(dev, eRfSleep, RF_CHANGE_BY_PS);
 }
 
@@ -50,14 +46,11 @@ void rtl92e_hw_wakeup(struct net_device *dev)
        spin_lock_irqsave(&priv->rf_ps_lock, flags);
        if (priv->rf_change_in_progress) {
                spin_unlock_irqrestore(&priv->rf_ps_lock, flags);
-               RT_TRACE(COMP_DBG,
-                        "%s(): RF Change in progress!\n", __func__);
                schedule_delayed_work(&priv->rtllib->hw_wakeup_wq,
                                      msecs_to_jiffies(10));
                return;
        }
        spin_unlock_irqrestore(&priv->rf_ps_lock, flags);
-       RT_TRACE(COMP_PS, "%s()============>come to wake up\n", __func__);
        rtl92e_set_rf_state(dev, eRfOn, RF_CHANGE_BY_PS);
 }
 
@@ -110,15 +103,10 @@ static void _rtl92e_ps_update_rf_state(struct net_device *dev)
        struct rt_pwr_save_ctrl *pPSC = (struct rt_pwr_save_ctrl *)
                                        &(priv->rtllib->PowerSaveControl);
 
-       RT_TRACE(COMP_PS, "%s() --------->\n", __func__);
        pPSC->bSwRfProcessing = true;
-
-       RT_TRACE(COMP_PS, "%s(): Set RF to %s.\n", __func__,
-                pPSC->eInactivePowerState == eRfOff ? "OFF" : "ON");
        rtl92e_set_rf_state(dev, pPSC->eInactivePowerState, RF_CHANGE_BY_IPS);
 
        pPSC->bSwRfProcessing = false;
-       RT_TRACE(COMP_PS, "%s() <---------\n", __func__);
 }
 
 void rtl92e_ips_enter(struct net_device *dev)
@@ -133,7 +121,6 @@ void rtl92e_ips_enter(struct net_device *dev)
                if (rt_state == eRfOn && !pPSC->bSwRfProcessing &&
                        (priv->rtllib->state != RTLLIB_LINKED) &&
                        (priv->rtllib->iw_mode != IW_MODE_MASTER)) {
-                       RT_TRACE(COMP_PS, "%s(): Turn off RF.\n", __func__);
                        pPSC->eInactivePowerState = eRfOff;
                        priv->isRFOff = true;
                        priv->bInPowerSaveMode = true;
@@ -153,7 +140,6 @@ void rtl92e_ips_leave(struct net_device *dev)
                rt_state = priv->rtllib->eRFPowerState;
                if (rt_state != eRfOn  && !pPSC->bSwRfProcessing &&
                    priv->rtllib->RfOffReason <= RF_CHANGE_BY_IPS) {
-                       RT_TRACE(COMP_PS, "%s(): Turn on RF.\n", __func__);
                        pPSC->eInactivePowerState = eRfOn;
                        priv->bInPowerSaveMode = false;
                        _rtl92e_ps_update_rf_state(dev);
@@ -210,7 +196,6 @@ static bool _rtl92e_ps_set_mode(struct net_device *dev, u8 rtPsMode)
        if (priv->rtllib->iw_mode == IW_MODE_ADHOC)
                return false;
 
-       RT_TRACE(COMP_LPS, "%s(): set ieee->ps = %x\n", __func__, rtPsMode);
        if (!priv->ps_force)
                priv->rtllib->ps = rtPsMode;
        if (priv->rtllib->sta_sleep != LPS_IS_WAKE &&
@@ -221,8 +206,6 @@ static bool _rtl92e_ps_set_mode(struct net_device *dev, u8 rtPsMode)
                priv->rtllib->sta_sleep = LPS_IS_WAKE;
 
                spin_lock_irqsave(&(priv->rtllib->mgmt_tx_lock), flags);
-               RT_TRACE(COMP_DBG,
-                        "LPS leave: notify AP we are awaked ++++++++++ SendNullFunctionData\n");
                rtllib_sta_ps_send_null_frame(priv->rtllib, 0);
                spin_unlock_irqrestore(&(priv->rtllib->mgmt_tx_lock), flags);
        }
@@ -236,12 +219,6 @@ void rtl92e_leisure_ps_enter(struct net_device *dev)
        struct rt_pwr_save_ctrl *pPSC = (struct rt_pwr_save_ctrl *)
                                        &(priv->rtllib->PowerSaveControl);
 
-       RT_TRACE(COMP_PS, "%s()...\n", __func__);
-       RT_TRACE(COMP_PS,
-                "pPSC->bLeisurePs = %d, ieee->ps = %d,pPSC->LpsIdleCount is %d,RT_CHECK_FOR_HANG_PERIOD is %d\n",
-                pPSC->bLeisurePs, priv->rtllib->ps, pPSC->LpsIdleCount,
-                RT_CHECK_FOR_HANG_PERIOD);
-
        if (!((priv->rtllib->iw_mode == IW_MODE_INFRA) &&
            (priv->rtllib->state == RTLLIB_LINKED))
            || (priv->rtllib->iw_mode == IW_MODE_ADHOC) ||
@@ -252,10 +229,6 @@ void rtl92e_leisure_ps_enter(struct net_device *dev)
                if (pPSC->LpsIdleCount >= RT_CHECK_FOR_HANG_PERIOD) {
 
                        if (priv->rtllib->ps == RTLLIB_PS_DISABLED) {
-
-                               RT_TRACE(COMP_LPS,
-                                        "%s(): Enter 802.11 power save mode...\n", __func__);
-
                                if (!pPSC->bFwCtrlLPS) {
                                        if (priv->rtllib->SetFwCmdHandler)
                                                priv->rtllib->SetFwCmdHandler(
@@ -275,15 +248,8 @@ void rtl92e_leisure_ps_leave(struct net_device *dev)
        struct rt_pwr_save_ctrl *pPSC = (struct rt_pwr_save_ctrl *)
                                        &(priv->rtllib->PowerSaveControl);
 
-
-       RT_TRACE(COMP_PS, "%s()...\n", __func__);
-       RT_TRACE(COMP_PS, "pPSC->bLeisurePs = %d, ieee->ps = %d\n",
-               pPSC->bLeisurePs, priv->rtllib->ps);
-
        if (pPSC->bLeisurePs) {
                if (priv->rtllib->ps != RTLLIB_PS_DISABLED) {
-                       RT_TRACE(COMP_LPS,
-                                "%s(): Busy Traffic , Leave 802.11 power save..\n", __func__);
                        _rtl92e_ps_set_mode(dev, RTLLIB_PS_DISABLED);
 
                        if (!pPSC->bFwCtrlLPS) {