fbdev/mmpfb: Use fbdev I/O helpers
authorThomas Zimmermann <tzimmermann@suse.de>
Thu, 3 Aug 2023 18:35:50 +0000 (20:35 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Fri, 4 Aug 2023 13:54:36 +0000 (15:54 +0200)
Set struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v3:
* use _IOMEM_ in commit message
v2:
* updated to use _IOMEM_ tokens

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Helge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-26-tzimmermann@suse.de
drivers/video/fbdev/mmp/fb/Kconfig
drivers/video/fbdev/mmp/fb/mmpfb.c

index 0ec2e3fb9e17582355c9dc3092093269f6e7e1e8..b13882b34e79b9f1655645182f8c44d27cdf9def 100644 (file)
@@ -2,9 +2,7 @@
 config MMP_FB
        tristate "fb driver for Marvell MMP Display Subsystem"
        depends on FB
-       select FB_CFB_FILLRECT
-       select FB_CFB_COPYAREA
-       select FB_CFB_IMAGEBLIT
+       select FB_IOMEM_HELPERS
        default y
        help
                fb driver for Marvell MMP Display Subsystem
index ac9db01f29f234d539cf7c12bc9f666db137a915..42a87474bceadf8139465c0c1147cbbc89622159 100644 (file)
@@ -454,14 +454,12 @@ static int mmpfb_blank(int blank, struct fb_info *info)
 
 static const struct fb_ops mmpfb_ops = {
        .owner          = THIS_MODULE,
+       FB_DEFAULT_IOMEM_OPS,
        .fb_blank       = mmpfb_blank,
        .fb_check_var   = mmpfb_check_var,
        .fb_set_par     = mmpfb_set_par,
        .fb_setcolreg   = mmpfb_setcolreg,
        .fb_pan_display = mmpfb_pan_display,
-       .fb_fillrect    = cfb_fillrect,
-       .fb_copyarea    = cfb_copyarea,
-       .fb_imageblit   = cfb_imageblit,
 };
 
 static int modes_setup(struct mmpfb_info *fbi)