ntb_tool: pass correct struct device to dma_alloc_coherent
authorSanjay R Mehta <sanju.mehta@amd.com>
Wed, 6 May 2020 04:21:50 +0000 (23:21 -0500)
committerJon Mason <jdmason@kudzu.us>
Sat, 6 Jun 2020 00:02:08 +0000 (20:02 -0400)
Currently, ntb->dev is passed to dma_alloc_coherent
and dma_free_coherent calls. The returned dma_addr_t
is the CPU physical address. This works fine as long
as IOMMU is disabled. But when IOMMU is enabled, we
need to make sure that IOVA is returned for dma_addr_t.
So the correct way to achieve this is by changing the
first parameter of dma_alloc_coherent() as ntb->pdev->dev
instead.

Fixes: 5648e56d03fa ("NTB: ntb_perf: Add full multi-port NTB API support")
Signed-off-by: Sanjay R Mehta <sanju.mehta@amd.com>
Signed-off-by: Arindam Nath <arindam.nath@amd.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
drivers/ntb/test/ntb_tool.c

index 69da758fe64c896eee4fd0d50dd946c4104ce58b..9eaeb221d98022f8cf3319ff88915d688da1b650 100644 (file)
@@ -590,7 +590,7 @@ static int tool_setup_mw(struct tool_ctx *tc, int pidx, int widx,
        inmw->size = min_t(resource_size_t, req_size, size);
        inmw->size = round_up(inmw->size, addr_align);
        inmw->size = round_up(inmw->size, size_align);
-       inmw->mm_base = dma_alloc_coherent(&tc->ntb->dev, inmw->size,
+       inmw->mm_base = dma_alloc_coherent(&tc->ntb->pdev->dev, inmw->size,
                                           &inmw->dma_base, GFP_KERNEL);
        if (!inmw->mm_base)
                return -ENOMEM;
@@ -612,7 +612,7 @@ static int tool_setup_mw(struct tool_ctx *tc, int pidx, int widx,
        return 0;
 
 err_free_dma:
-       dma_free_coherent(&tc->ntb->dev, inmw->size, inmw->mm_base,
+       dma_free_coherent(&tc->ntb->pdev->dev, inmw->size, inmw->mm_base,
                          inmw->dma_base);
        inmw->mm_base = NULL;
        inmw->dma_base = 0;
@@ -629,7 +629,7 @@ static void tool_free_mw(struct tool_ctx *tc, int pidx, int widx)
 
        if (inmw->mm_base != NULL) {
                ntb_mw_clear_trans(tc->ntb, pidx, widx);
-               dma_free_coherent(&tc->ntb->dev, inmw->size,
+               dma_free_coherent(&tc->ntb->pdev->dev, inmw->size,
                                  inmw->mm_base, inmw->dma_base);
        }