KVM: selftests: aarch64: Remove unused functions from vpmu test
authorRaghavendra Rao Ananta <rananta@google.com>
Wed, 22 Nov 2023 22:15:26 +0000 (22:15 +0000)
committerOliver Upton <oliver.upton@linux.dev>
Thu, 29 Feb 2024 06:36:15 +0000 (06:36 +0000)
vpmu_counter_access's disable_counter() carries a bug that disables
all the counters that are enabled, instead of just the requested one.
Fortunately, it's not an issue as there are no callers of it. Hence,
instead of fixing it, remove the definition entirely.

Remove enable_counter() as it's unused as well.

Signed-off-by: Raghavendra Rao Ananta <rananta@google.com>
Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>
Link: https://lore.kernel.org/r/20231122221526.2750966-1-rananta@google.com
Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
tools/testing/selftests/kvm/aarch64/vpmu_counter_access.c

index f8f0c655c7232e19e3aa73912da4c0d8426da9bb..1b51cd11ee93ca471ea4a9e6f9ea13c3d651bb83 100644 (file)
@@ -93,22 +93,6 @@ static inline void write_sel_evtyper(int sel, unsigned long val)
        isb();
 }
 
-static inline void enable_counter(int idx)
-{
-       uint64_t v = read_sysreg(pmcntenset_el0);
-
-       write_sysreg(BIT(idx) | v, pmcntenset_el0);
-       isb();
-}
-
-static inline void disable_counter(int idx)
-{
-       uint64_t v = read_sysreg(pmcntenset_el0);
-
-       write_sysreg(BIT(idx) | v, pmcntenclr_el0);
-       isb();
-}
-
 static void pmu_disable_reset(void)
 {
        uint64_t pmcr = read_sysreg(pmcr_el0);