xfs: fix unused variable warning in buffer completion on !DEBUG
authorBrian Foster <bfoster@redhat.com>
Fri, 8 May 2020 15:50:52 +0000 (08:50 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Fri, 8 May 2020 15:50:52 +0000 (08:50 -0700)
The random buffer write failure errortag patch introduced a local
mount pointer variable for the test macro, but the macro is compiled
out on !DEBUG kernels. This results in an unused variable warning.

Access the mount structure through the buffer pointer and remove the
local mount pointer to address the warning.

Fixes: 7376d745473 ("xfs: random buffer write failure errortag")
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/xfs_buf.c

index 9d8841ac7375c86507273ea94766502bdbda8ff7..9c2fbb6bbf89de3bfe4db950904fb8f7fdc44fdb 100644 (file)
@@ -1289,11 +1289,10 @@ xfs_buf_bio_end_io(
        struct bio              *bio)
 {
        struct xfs_buf          *bp = (struct xfs_buf *)bio->bi_private;
-       struct xfs_mount        *mp = bp->b_mount;
 
        if (!bio->bi_status &&
            (bp->b_flags & XBF_WRITE) && (bp->b_flags & XBF_ASYNC) &&
-           XFS_TEST_ERROR(false, mp, XFS_ERRTAG_BUF_IOERROR))
+           XFS_TEST_ERROR(false, bp->b_mount, XFS_ERRTAG_BUF_IOERROR))
                bio->bi_status = BLK_STS_IOERR;
 
        /*