power: supply: mm8013: Fix error code in mm8013_probe()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Sat, 23 Sep 2023 11:48:06 +0000 (04:48 -0700)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Sun, 24 Sep 2023 20:51:55 +0000 (22:51 +0200)
The value of ret is zero when passed to dev_error_probe(), we are passing
zero to dev_err_probe() is a success which is incorrect.

Fix this by getting the error code using PTR_ERR().

Fixes: c75f4bf6800b ("power: supply: Introduce MM8013 fuel gauge driver")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/r/202309190838.eu8WS6sz-lkp@intel.com/
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://lore.kernel.org/r/20230923114807.2829188-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/mm8013.c

index ddac40ef9ae53dace43e91f1e907b64bd25eccb8..29fd65fe6545ae6be27a6515c37734ab38b8133d 100644 (file)
@@ -273,8 +273,10 @@ static int mm8013_probe(struct i2c_client *client)
        chip->client = client;
 
        chip->regmap = devm_regmap_init_i2c(client, &mm8013_regmap_config);
-       if (IS_ERR(chip->regmap))
+       if (IS_ERR(chip->regmap)) {
+               ret = PTR_ERR(chip->regmap);
                return dev_err_probe(dev, ret, "Couldn't initialize regmap\n");
+       }
 
        ret = mm8013_checkdevice(chip);
        if (ret)