m68k: mm: Remove stray nocache in ColdFire pgalloc
authorPeter Zijlstra <peterz@infradead.org>
Fri, 31 Jan 2020 12:45:32 +0000 (13:45 +0100)
committerGeert Uytterhoeven <geert@linux-m68k.org>
Mon, 10 Feb 2020 09:57:48 +0000 (10:57 +0100)
Since ColdFire V4e is a software TLB-miss architecture, there is no
need for page-tables to be mapped uncached. Remove this stray
nocache_page() dance, which isn't paired with a cache_page() and looks
like a copy/paste/edit fail.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Will Deacon <will@kernel.org>
Acked-by: Greg Ungerer <gerg@linux-m68k.org>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Tested-by: Greg Ungerer <gerg@linux-m68k.org>
Link: https://lore.kernel.org/r/20200131125403.481739981@infradead.org
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
arch/m68k/include/asm/mcf_pgalloc.h

index 82ec54c2eaa46cb14b22d8c5af25c52dd3065df9..cb0e36fb2a606360cf4e2bc911b42715df8430ff 100644 (file)
@@ -55,12 +55,8 @@ static inline struct page *pte_alloc_one(struct mm_struct *mm)
        }
 
        pte = kmap(page);
-       if (pte) {
+       if (pte)
                clear_page(pte);
-               __flush_page_to_ram(pte);
-               flush_tlb_kernel_page(pte);
-               nocache_page(pte);
-       }
        kunmap(page);
 
        return page;