vdpa/mlx5: Directly assign memory key
authorEli Cohen <elic@nvidia.com>
Sun, 5 Feb 2023 07:29:06 +0000 (09:29 +0200)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 21 Feb 2023 00:26:59 +0000 (19:26 -0500)
When creating a memory key, the key value should be assigned to the
passed pointer and not or'ed to.

No functional issue was observed due to this bug.

Fixes: 29064bfdabd5 ("vdpa/mlx5: Add support library for mlx5 VDPA implementation")
Signed-off-by: Eli Cohen <elic@nvidia.com>
Message-Id: <20230205072906.1108194-1-elic@nvidia.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/vdpa/mlx5/core/resources.c

index 9800f9bec225a5fe0ad7b4b5fb4bba0646e0e0f1..45ad41287a317ce7e5d9c027af9da75222c2e38a 100644 (file)
@@ -213,7 +213,7 @@ int mlx5_vdpa_create_mkey(struct mlx5_vdpa_dev *mvdev, u32 *mkey, u32 *in,
                return err;
 
        mkey_index = MLX5_GET(create_mkey_out, lout, mkey_index);
-       *mkey |= mlx5_idx_to_mkey(mkey_index);
+       *mkey = mlx5_idx_to_mkey(mkey_index);
        return 0;
 }