char: tpm: move to use request_irq by IRQF_NO_AUTOEN flag
authorTian Tao <tiantao6@hisilicon.com>
Mon, 17 May 2021 01:18:44 +0000 (09:18 +0800)
committerJarkko Sakkinen <jarkko@kernel.org>
Wed, 23 Jun 2021 13:51:03 +0000 (16:51 +0300)
disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable because of requesting.

Link: https://lore.kernel.org/patchwork/patch/1388765/
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
drivers/char/tpm/tpm_tis_i2c_cr50.c

index f19c227d20f485f4151c5b8f7e6cf926eb5474b6..44dde2fbe2fbcce1372579d63f78bb44b424e8aa 100644 (file)
@@ -706,14 +706,14 @@ static int tpm_cr50_i2c_probe(struct i2c_client *client,
 
        if (client->irq > 0) {
                rc = devm_request_irq(dev, client->irq, tpm_cr50_i2c_int_handler,
-                                     IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+                                     IRQF_TRIGGER_FALLING | IRQF_ONESHOT |
+                                     IRQF_NO_AUTOEN,
                                      dev->driver->name, chip);
                if (rc < 0) {
                        dev_err(dev, "Failed to probe IRQ %d\n", client->irq);
                        return rc;
                }
 
-               disable_irq(client->irq);
                priv->irq = client->irq;
        } else {
                dev_warn(dev, "No IRQ, will use %ums delay for TPM ready\n",