ARM: dts: BCM53573: Fix Ethernet info for Luxul devices
authorRafał Miłecki <rafal@milecki.pl>
Thu, 13 Jul 2023 11:11:45 +0000 (13:11 +0200)
committerFlorian Fainelli <florian.fainelli@broadcom.com>
Fri, 21 Jul 2023 16:58:01 +0000 (09:58 -0700)
Both Luxul's XAP devices (XAP-810 and XAP-1440) are access points that
use a non-default design. They don't include switch but have a single
Ethernet port and BCM54210E PHY connected to the Ethernet controller's
MDIO bus.

Support for those devices regressed due to two changes:

1. Describing MDIO bus with switch
After commit 9fb90ae6cae7 ("ARM: dts: BCM53573: Describe on-SoC BCM53125
rev 4 switch") Linux stopped probing for MDIO devices.

2. Dropping hardcoded BCM54210E delays
In commit fea7fda7f50a ("net: phy: broadcom: Fix RGMII delays
configuration for BCM54210E") support for other PHY modes was added but
that requires a proper "phy-mode" value in DT.

Both above changes are correct (they don't need to be reverted or
anything) but they need this fix for DT data to be correct and for Linux
to work properly.

Fixes: 9fb90ae6cae7 ("ARM: dts: BCM53573: Describe on-SoC BCM53125 rev 4 switch")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Link: https://lore.kernel.org/r/20230713111145.14864-1-zajec5@gmail.com
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts
arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-810.dts

index b9dd5084441986ab08494670dbd2b1519b6809a5..0f6d7fe30068f322e547b72170aa98536743ed97 100644 (file)
                };
        };
 };
+
+&gmac0 {
+       phy-mode = "rgmii";
+       phy-handle = <&bcm54210e>;
+
+       mdio {
+               /delete-node/ switch@1e;
+
+               bcm54210e: ethernet-phy@0 {
+                       reg = <0>;
+               };
+       };
+};
index cb22ae2a02e54d5365ad127dd9342e98fe832b4c..4e0ef0af726f52c6aa7a3f43dc9ac3f515453d7c 100644 (file)
                };
        };
 };
+
+&gmac0 {
+       phy-mode = "rgmii";
+       phy-handle = <&bcm54210e>;
+
+       mdio {
+               /delete-node/ switch@1e;
+
+               bcm54210e: ethernet-phy@0 {
+                       reg = <0>;
+               };
+       };
+};