scsi: isci: Don't use PCI helper functions
authorVaibhav Gupta <vaibhavgupta40@gmail.com>
Sat, 7 Nov 2020 10:04:19 +0000 (15:34 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 11 Nov 2020 04:08:36 +0000 (23:08 -0500)
PCI helper functions such as pci_enable/disable_device(),
pci_save/restore_state(), pci_set_power_state(), etc. were used by the
legacy framework to perform standard operations related to PCI PM.

This driver is using the generic framework and thus calls for those
functions should be dropped as those tasks are now performed by the PCI
core.

Link: https://lore.kernel.org/r/20201107100420.149521-1-vaibhavgupta40@gmail.com
Acked-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/isci/init.c

index 93bc9019667f143cb113ae8441df0a860272d310..c452849e7bb43c3bfdc222f1ae562aaae3e5a060 100644 (file)
@@ -715,10 +715,6 @@ static int isci_suspend(struct device *dev)
                isci_host_deinit(ihost);
        }
 
-       pci_save_state(pdev);
-       pci_disable_device(pdev);
-       pci_set_power_state(pdev, PCI_D3hot);
-
        return 0;
 }
 
@@ -726,19 +722,7 @@ static int isci_resume(struct device *dev)
 {
        struct pci_dev *pdev = to_pci_dev(dev);
        struct isci_host *ihost;
-       int rc, i;
-
-       pci_set_power_state(pdev, PCI_D0);
-       pci_restore_state(pdev);
-
-       rc = pcim_enable_device(pdev);
-       if (rc) {
-               dev_err(&pdev->dev,
-                       "enabling device failure after resume(%d)\n", rc);
-               return rc;
-       }
-
-       pci_set_master(pdev);
+       int i;
 
        for_each_isci_host(i, ihost, pdev) {
                sas_prep_resume_ha(&ihost->sas_ha);